feat: strong equality matcher #1733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metacosm
reviewed
Jan 25, 2023
| @@ -61,6 +66,9 @@ public static <R extends HasMetadata> Result<R> match(R desired, R actualResourc | |||
| var desiredSpecNode = objectMapper.valueToTree(ReconcilerUtils.getSpec(desired)); | |||
| var actualSpecNode = objectMapper.valueToTree(ReconcilerUtils.getSpec(actualResource)); | |||
| var diffJsonPatch = JsonDiff.asJson(desiredSpecNode, actualSpecNode); | |||
| if (strongEquality && diffJsonPatch.size() > 0) { | |||
There was a problem hiding this comment.
A comment as to why this determines that things are not equal according to "strong equality" would be helpful. For that matter, defining what strong equality is would be helpful! 😄
There was a problem hiding this comment.
renamed to equality, added detailed javadoc
metacosm
requested changes
Feb 7, 2023
| @@ -61,6 +90,9 @@ public static <R extends HasMetadata> Result<R> match(R desired, R actualResourc | |||
| var desiredSpecNode = objectMapper.valueToTree(ReconcilerUtils.getSpec(desired)); | |||
| var actualSpecNode = objectMapper.valueToTree(ReconcilerUtils.getSpec(actualResource)); | |||
| var diffJsonPatch = JsonDiff.asJson(desiredSpecNode, actualSpecNode); | |||
| if (equality && diffJsonPatch.size() > 0) { | |||
There was a problem hiding this comment.
Still would like a comment here to explain why this makes a difference
metacosm
reviewed
Feb 8, 2023
...vaoperatorsdk/operator/processing/dependent/kubernetes/GenericKubernetesResourceMatcher.java
Outdated
Show resolved
Hide resolved
metacosm
reviewed
Feb 8, 2023
...vaoperatorsdk/operator/processing/dependent/kubernetes/GenericKubernetesResourceMatcher.java
Outdated
Show resolved
Hide resolved
metacosm
approved these changes
Feb 8, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.